🧪 [testing improvement] Add missing context test for analyze_reasoning in observability.rs#29
Conversation
…g in observability.rs This commit adds two new test cases to `cuba_cognitive_engine/src/server/observability.rs`: - `test_tool_metrics_zero_duration`: Verifies that `ToolMetrics` correctly handles a record with zero duration. - `test_analyze_reasoning_zero_duration`: Specifically tests the `analyze_reasoning` tool metric within `RedMetrics` with zero duration, simulating a missing/empty context scenario. Both tests ensure that the request counts are correctly incremented and that durations (average and max) remain consistent (0.0 ms) for zero-duration calls. Co-authored-by: LeandroPG19 <151863062+LeandroPG19@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🎯 What: The testing gap addressed: added tests for zero-duration calls to the
analyze_reasoningtool metric and the underlyingToolMetricsstruct.📊 Coverage:
ToolMetrics::recordwithDuration::ZERO.RedMetrics::record_callforanalyze_reasoningwithDuration::ZERO.✨ Result: Improved test coverage for edge cases in the observability module, ensuring that near-instantaneous or empty context calls are correctly accounted for in the metrics.
PR created automatically by Jules for task 9140444289384738845 started by @LeandroPG19